Fixed a simple bug where the cw side tone did not change on uBITX Transceiver#2
Open
phdlee wants to merge 1 commit intoafarhan:masterfrom
Open
Fixed a simple bug where the cw side tone did not change on uBITX Transceiver#2phdlee wants to merge 1 commit intoafarhan:masterfrom
phdlee wants to merge 1 commit intoafarhan:masterfrom
Conversation
This was referenced Jan 3, 2018
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dear afarhan
I found a minor bug and made the following changes:
I downloaded uBITX 2.0 source code and compiled it.
1.There is no response when PTT is pressed after CW side tone is set.
https://www.youtube.com/watch?v=1EPPknBQNLY
2.It works perfectly, However, the changed side tone is initialized when the power is turned off and on again.
https://www.youtube.com/watch?v=5eZyQAyrsvM
This simple problem can also be easily corrected.
3.It works perfectly all, change to cw side band (pitch), save to eeprom.
https://www.youtube.com/watch?v=wMFvJ33JS1I
modified just 2 lines
thank afarhan for making this very fun uBITX and good performance.
For a happy ham life with uBITX
Best 73
DE KD8CEC / Ph.D Ian lee
kd8cec@gmail.com